alamb commented on a change in pull request #1580:
URL: https://github.com/apache/arrow-datafusion/pull/1580#discussion_r785436677
##########
File path: datafusion/src/logical_plan/expr.rs
##########
@@ -372,6 +373,23 @@ pub enum Expr {
Wildcard,
}
+/// Fixed seed for the hashing so that Ords are consistent across runs
Review comment:
👍
##########
File path: datafusion/src/logical_plan/window_frames.rs
##########
@@ -190,6 +191,12 @@ impl Ord for WindowFrameBound {
}
}
+impl Hash for WindowFrameBound {
+ fn hash<H: Hasher>(&self, state: &mut H) {
+ self.get_rank().hash(state)
Review comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
