toppyy commented on pull request #12083: URL: https://github.com/apache/arrow/pull/12083#issuecomment-1013892092
I reverted the previous commits and implemented the following logic in `CsvFileFormat$create` as discussed: If a schema is specified and column names are set in read_options, we raise an error if the two do not match. Also added a note of this in the documentation. I thought about the documentation aspect a bit. As a starting point, I added link to [read_csv_arrow](https://arrow.apache.org/docs/r/reference/read_delim_arrow.html) into `open_dataset` docs. It has some explanation on how to specify column names and types. Though I suspect this might be a bit misleading for the readers who are unaware of the fact that both functions end up calling `CsvReadOptions$create`. It seems to that the `open_dataset` docs (or the cookbook) might benefit from additional examples or a separate section (like in read_csv_arrow) on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
