yordan-pavlov commented on a change in pull request #1082:
URL: https://github.com/apache/arrow-rs/pull/1082#discussion_r785493522
##########
File path: parquet/benches/arrow_array_reader.rs
##########
@@ -366,10 +366,10 @@ fn add_benches(c: &mut Criterion) {
mandatory_int32_column_desc.clone(),
);
count = bench_array_reader(array_reader);
+ assert_eq!(count, EXPECTED_VALUE_COUNT);
Review comment:
with this change, doesn't `assert_eq!(count, EXPECTED_VALUE_COUNT);`
become part of the benchmarked code? yes, it should have minimal to no impact,
but my concern is more about keeping the benchmark as clean as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
