liukun4515 commented on a change in pull request #1483:
URL: https://github.com/apache/arrow-datafusion/pull/1483#discussion_r785624268
##########
File path: datafusion/src/physical_plan/expressions/binary.rs
##########
@@ -79,6 +76,193 @@ fn is_not_distinct_from_bool(
.collect())
}
+// TODO add iter for decimal array
+// TODO move this to arrow-rs
+// https://github.com/apache/arrow-rs/issues/1083
+pub(super) fn eq_decimal_scalar(
+ left: &DecimalArray,
+ right: i128,
+) -> Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) == right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+pub(super) fn eq_decimal(
+ left: &DecimalArray,
+ right: &DecimalArray,
+) -> Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) == right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn neq_decimal_scalar(left: &DecimalArray, right: i128) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) != right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn neq_decimal(left: &DecimalArray, right: &DecimalArray) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) != right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn lt_decimal_scalar(left: &DecimalArray, right: i128) -> Result<BooleanArray>
{
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) < right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn lt_decimal(left: &DecimalArray, right: &DecimalArray) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) < right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn lt_eq_decimal_scalar(left: &DecimalArray, right: i128) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) <= right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn lt_eq_decimal(left: &DecimalArray, right: &DecimalArray) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) <= right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn gt_decimal_scalar(left: &DecimalArray, right: i128) -> Result<BooleanArray>
{
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) > right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn gt_decimal(left: &DecimalArray, right: &DecimalArray) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) > right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn gt_eq_decimal_scalar(left: &DecimalArray, right: i128) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) >= right)?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn gt_eq_decimal(left: &DecimalArray, right: &DecimalArray) ->
Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_null()?;
+ } else {
+ bool_builder.append_value(left.value(i) >= right.value(i))?;
+ }
+ }
+ Ok(bool_builder.finish())
+}
+
+fn is_distinct_from_decimal(
+ left: &DecimalArray,
+ right: &DecimalArray,
+) -> Result<BooleanArray> {
+ let mut bool_builder = BooleanBuilder::new(left.len());
+ for i in 0..left.len() {
+ if left.is_null(i) && right.is_null(i) {
+ bool_builder.append_value(false)?;
+ } else if left.is_null(i) || right.is_null(i) {
+ bool_builder.append_value(true)?;
+ } else {
+ bool_builder.append_value(left.value(i) != right.value(i))?;
Review comment:
it's great and it will be resolved in
https://github.com/apache/arrow-datafusion/pull/1554/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
