lidavidm commented on a change in pull request #12100:
URL: https://github.com/apache/arrow/pull/12100#discussion_r786021110
##########
File path: cpp/src/arrow/compute/exec/sink_node.cc
##########
@@ -275,6 +302,11 @@ struct OrderBySinkNode final : public SinkNode {
}
void InputReceived(ExecNode* input, ExecBatch batch) override {
+ EVENT(span_, "InputReceived", {{"batch.length", batch.length}});
+ util::tracing::Span span;
+ START_SPAN_WITH_PARENT(span, span_, "InputReceived",
+ {{"node.label", label()}, {"batch.length",
batch.length}});
+
Review comment:
From one of the screenshots above, it might be worth instrumenting
DoFinish below for OrderBySinkNode since that's where the 'real' work happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
