dragosmg commented on a change in pull request #12179: URL: https://github.com/apache/arrow/pull/12179#discussion_r787576778
########## File path: r/tests/testthat/test-dplyr-join.R ########## @@ -90,9 +90,57 @@ test_that("Error handling", { left_tab %>% left_join(to_join, by = "not_a_col") %>% collect(), - "all(names(by) %in% names(x)) is not TRUE", - fixed = TRUE + "Join column must be present in data" ) + expect_snapshot({ + (expect_error( Review comment: I'd be in favour of keeping those extra brackets `()` in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org