jvictorhuguenin commented on a change in pull request #10425:
URL: https://github.com/apache/arrow/pull/10425#discussion_r790089526
##########
File path: cpp/src/gandiva/precompiled/time_test.cc
##########
@@ -382,6 +386,29 @@ TEST(TestTime, TimeStampAdd) {
EXPECT_EQ(add_date64_int64(StringToTimestamp("2000-02-27 00:00:00"), 4),
StringToTimestamp("2000-03-02 00:00:00"));
+ EXPECT_EQ(add_timestamp_month_interval(StringToTimestamp("2000-02-27
00:00:00"), 4),
Review comment:
Done, I couldn't use the limit for INT32 on month_interval because if I
did it it would overflow the timestamp result, since it's adds
INT32_MAX*millis_in_a_month, so the result would be to big to int64 to handle.
Also I did not added tests for daytime intervals in the type limit because it
returns some timestamps too big to make even sense like 185543538537600000
##########
File path: cpp/src/gandiva/precompiled/time_test.cc
##########
@@ -397,6 +424,36 @@ TEST(TestTime, TimeStampAdd) {
EXPECT_EQ(date_diff_timestamp_int64(StringToTimestamp("2000-02-29
00:00:00"), 365),
StringToTimestamp("1999-03-01 00:00:00"));
+
+ EXPECT_EQ(
+ subtract_timestamp_month_interval(StringToTimestamp("2000-02-27
00:00:00"), 4),
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
