rok commented on a change in pull request #12136:
URL: https://github.com/apache/arrow/pull/12136#discussion_r791270772
##########
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##########
@@ -1693,7 +1692,9 @@ struct ArithmeticFunction : ScalarFunction {
if (values->size() == 2) {
ReplaceNullWithOtherType(values);
- if (auto type = CommonNumeric(*values)) {
+ if (auto type = CommonTemporal(values->data(), values->size())) {
Review comment:
Added `CommonTemporalResolution` and refactored `ReplaceTemporalTypes`.
This PR should hopefully cover all temporal casts needed for
[ARROW-11901](https://issues.apache.org/jira/browse/ARROW-11901).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
