tustvold commented on a change in pull request #1238:
URL: https://github.com/apache/arrow-rs/pull/1238#discussion_r791568279
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -3843,6 +3960,114 @@ mod tests {
assert_eq!(neq_dyn_scalar(&array, 8).unwrap(), expected);
}
+ #[test]
+ fn test_eq_dyn_binary_scalar() {
+ let array = BinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let large_array = LargeBinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let scalar = "flight".as_bytes();
+ let expected = BooleanArray::from(vec![false, false, true, false,
false]);
+
+ assert_eq!(eq_dyn_binary_scalar(&array, scalar).unwrap(), expected);
+ assert_eq!(
+ eq_dyn_binary_scalar(&large_array, scalar).unwrap(),
+ expected
+ );
+ }
+
+ #[test]
+ fn test_neq_dyn_binary_scalar() {
+ let array = BinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let large_array = LargeBinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let scalar = "flight".as_bytes();
+ let expected = BooleanArray::from(vec![true, true, false, true, true]);
+
+ assert_eq!(neq_dyn_binary_scalar(&array, scalar).unwrap(), expected);
+ assert_eq!(
+ neq_dyn_binary_scalar(&large_array, scalar).unwrap(),
+ expected
+ );
+ }
+
+ #[test]
+ fn test_lt_dyn_binary_scalar() {
+ let array = BinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let large_array = LargeBinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let scalar = "flight".as_bytes();
+ let expected = BooleanArray::from(vec![true, true, false, false,
false]);
+
+ assert_eq!(lt_dyn_binary_scalar(&array, scalar).unwrap(), expected);
+ assert_eq!(
+ lt_dyn_binary_scalar(&large_array, scalar).unwrap(),
+ expected
+ );
+ }
+
+ #[test]
+ fn test_lt_eq_dyn_binary_scalar() {
+ let array = BinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let large_array = LargeBinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let scalar = "flight".as_bytes();
+ let expected = BooleanArray::from(vec![true, true, true, false,
false]);
+
+ assert_eq!(lt_eq_dyn_binary_scalar(&array, scalar).unwrap(), expected);
+ assert_eq!(
+ lt_eq_dyn_binary_scalar(&large_array, scalar).unwrap(),
+ expected
+ );
+ }
+
+ #[test]
+ fn test_gt_dyn_binary_scalar() {
+ let array = BinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let large_array = LargeBinaryArray::from_vec(
+ vec![b"arrow", b"datafusion", b"flight", b"parquet", &[0xff,
0xf8]],
+ );
+ let scalar = "flight".as_bytes();
Review comment:
Perhaps one of these tests could use a non-UTF8 string as the scalar.
##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -3843,6 +3960,114 @@ mod tests {
assert_eq!(neq_dyn_scalar(&array, 8).unwrap(), expected);
}
+ #[test]
Review comment:
Perhaps we could get a test with nulls?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
