pitrou commented on a change in pull request #11916:
URL: https://github.com/apache/arrow/pull/11916#discussion_r791519069
##########
File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml
##########
@@ -81,6 +82,7 @@ outputs:
- lz4-c
- numpy
- orc # [unix]
+ - openssl
Review comment:
This is not already a dependency of `aws-sdk-cpp`, `grpc-cpp` or
`google-cloud-cpp`?
##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
##########
@@ -23,6 +23,7 @@ export PYARROW_WITH_PARQUET=1
export PYARROW_WITH_PLASMA=1
export PYARROW_WITH_S3=1
export PYARROW_CMAKE_GENERATOR=Ninja
+export PYARROW_CMAKE_OPTIONS="-DARROW_SIMD_LEVEL=NONE"
Review comment:
Hmm, can you add a comment explaining why this is needed?
##########
File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
##########
@@ -23,6 +23,7 @@ export PYARROW_WITH_PARQUET=1
export PYARROW_WITH_PLASMA=1
export PYARROW_WITH_S3=1
export PYARROW_CMAKE_GENERATOR=Ninja
+export PYARROW_CMAKE_OPTIONS="-DARROW_SIMD_LEVEL=NONE"
Review comment:
Can you open a JIRA for the ppc64le and aarch64 builds issue? I think
this should have been fixed already, so I'm a bit surprised (is cross-compiling
involved perhaps?).
NONE really means that we activate no SIMD ISA at compile time. Otherwise
you should keep that as DEFAULT.
##########
File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml
##########
@@ -81,6 +82,7 @@ outputs:
- lz4-c
- numpy
- orc # [unix]
+ - openssl
Review comment:
Ok, thanks for the explanation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
