kou commented on a change in pull request #12230:
URL: https://github.com/apache/arrow/pull/12230#discussion_r791168359
##########
File path: cpp/cmake_modules/BuildUtils.cmake
##########
@@ -370,7 +370,7 @@ function(ADD_ARROW_LIB LIB_NAME)
target_link_libraries(${LIB_NAME}_shared
LINK_PUBLIC
- "$<BUILD_INTERFACE:${ARG_SHARED_LINK_LIBS}>"
+ ${ARG_SHARED_LINK_LIBS}
Review comment:
It exports too much libraries to `ArrowTargets.cmake`. See also:
8ab1493c810ae354ce085c2c2052676f349b168a
What build error was solved by this change?
Could you show build log for this?
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -79,7 +79,7 @@ set(ARROW_THIRDPARTY_DEPENDENCIES
# supported when building with MSVC because of the way that
# conda-forge packages have 4 variants of the libraries packaged
# together
-if(MSVC AND "${GTest_SOURCE}" STREQUAL "")
+if(MSVC AND "${GTest_SOURCE}" STREQUAL "" AND "${ARROW_DEPENDENCY_SOURCE}"
STREQUAL "CONDA")
Review comment:
Could you show full build log on error?
I think that avoiding old header and new library mix is the real fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
