yjshen commented on a change in pull request #1682:
URL: https://github.com/apache/arrow-datafusion/pull/1682#discussion_r792652252
##########
File path: datafusion/src/physical_plan/mod.rs
##########
@@ -51,6 +51,11 @@ pub trait RecordBatchStream: Stream<Item =
ArrowResult<RecordBatch>> {
/// Implementation of this trait should guarantee that all `RecordBatch`'s
returned by this
/// stream should have the same schema as returned from this method.
fn schema(&self) -> SchemaRef;
+
+ /// Returns the current memory usage for this stream.
+ fn mem_used(&self) -> usize {
+ 0
+ }
Review comment:
After re-consider this for a while. I cannot think of a solution to
register `RecordBatchStream` somewhere else since each stream is used through
mutable reference. I don't think there's a way sharing it except for Arc<dyn
RecordBatchStream ....>, which we have discussed earlier and is not acceptable.
I'm going to revert this last commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
