jonkeane commented on a change in pull request #12240:
URL: https://github.com/apache/arrow/pull/12240#discussion_r792988199
##########
File path: r/tests/testthat/test-Array.R
##########
@@ -260,11 +260,10 @@ test_that("array supports POSIXct (ARROW-3340)", {
expect_array_roundtrip(times2, timestamp("us", "US/Eastern"))
})
-test_that("array supports POSIXct without timezone", {
- # Make sure timezone is not set
- withr::with_envvar(c(TZ = ""), {
+test_that("array uses local timezone for POSIXct without timezone", {
+ withr::with_envvar(c(TZ = "Asia/Ulaanbaatar"), {
Review comment:
I think we want to keep this test with `withr::with_envvar(c(TZ = ""),
{` like it is (though we will probably need to change the line below to be
something like `expect_array_roundtrip(times, timestamp("us", Sys.timezone()))`.
Additionally, we should have a test that is similar to this one that _also_
sets `withr::with_envvar(c(TZ = NA), {` since that is most like the
environments where someone has not actually proactively changed any of their
timezone settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
