tustvold commented on a change in pull request #1246:
URL: https://github.com/apache/arrow-rs/pull/1246#discussion_r795025401
##########
File path: parquet/src/arrow/array_reader.rs
##########
@@ -214,6 +214,10 @@ where
// save definition and repetition buffers
self.def_levels_buffer = self.record_reader.consume_def_levels()?;
self.rep_levels_buffer = self.record_reader.consume_rep_levels()?;
+
+ // Must consume bitmap buffer
+ self.record_reader.consume_bitmap_buffer()?;
Review comment:
Yeah, I didn't mean to suggest NullArrayReader itself is niche, but
rather there is probably a limited benefit to optimising it to not compute the
bitmask unnecessarily :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
