[GitHub] [arrow-datafusion] tustvold commented on a change in pull request #1732: Prevent repartitioning of certain operator's direct children (#1731)

[GitBox]

tustvold commented on a change in pull request #1732:
URL: https://github.com/apache/arrow-datafusion/pull/1732#discussion_r797843618



##########
File path: datafusion/tests/sql/explain_analyze.rs
##########
@@ -700,15 +700,15 @@ async fn 
test_physical_plan_display_indent_multi_children() {
         "    HashJoinExec: mode=Partitioned, join_type=Inner, on=[(Column { 
name: \"c1\", index: 0 }, Column { name: \"c2\", index: 0 })]",
         "      CoalesceBatchesExec: target_batch_size=4096",
         "        RepartitionExec: partitioning=Hash([Column { name: \"c1\", 
index: 0 }], 3)",
-        "          ProjectionExec: expr=[c1@0 as c1]",
+        "          RepartitionExec: partitioning=RoundRobinBatch(3)",

Review comment:
       This plan is a little bit strange, but not a strangeness introduced by 
this PR.
   
   Perhaps RepartitionExec should itself be should_repartition_children 
:thinking: 
   
   Edit: I did this in the end




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org