matthewmturner commented on a change in pull request #1715:
URL: https://github.com/apache/arrow-datafusion/pull/1715#discussion_r800753188
##########
File path: datafusion/src/datasource/listing/table.rs
##########
@@ -118,12 +195,17 @@ impl ListingTable {
/// The provided `schema` must be resolved before creating the table
/// and should contain the fields of the file without the table
/// partitioning columns.
- pub fn new(
- object_store: Arc<dyn ObjectStore>,
- table_path: String,
- file_schema: SchemaRef,
- options: ListingOptions,
- ) -> Self {
+ pub async fn new(mut config: ListingTableConfig) -> Result<Self> {
Review comment:
yes was planning on adding docs once i was sure API was good. and will
update to `try_new`!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
