realno commented on pull request #1729: URL: https://github.com/apache/arrow-datafusion/pull/1729#issuecomment-1032300254
The PR is ready for final review before merge. FYI, I decided not to add the changes for handling Projection and Alias because the change became quite cumbersome to handle all the corner cases - it needs to traverse the plan twice in order to properly register expression names and schemas; it also does a lot of copies along the way. With the existing approach, the only caveat is `ToApproxPerc` must be applied last. Considering it is simple and relatively efficient I decided to go with this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
