tustvold commented on a change in pull request #1284:
URL: https://github.com/apache/arrow-rs/pull/1284#discussion_r801512170
##########
File path: parquet/benches/arrow_reader.rs
##########
@@ -78,16 +78,15 @@ fn build_plain_encoded_int32_page_iterator(
max_def_level
};
if def_level == max_def_level {
- int32_value += 1;
- values.push(int32_value);
+ values.push(rng.gen_range(0..1000));
Review comment:
This change is to make the benchmark more realistic, a constant offset
between consecutive values is the optimal case for DeltaBitPackDecoder - the
min_delta will be 1, and all the miniblocks will have a bit width of 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
