dragosmg commented on a change in pull request #12357:
URL: https://github.com/apache/arrow/pull/12357#discussion_r803472886
##########
File path: r/R/dplyr-funcs-datetime.R
##########
@@ -147,5 +147,12 @@ register_bindings_datetime <- function() {
register_binding("pm", function(x) {
!call_binding("am", x)
})
-
+ register_binding("tz", function(x) {
+ if (call_binding("is.character", x) ||
+ call_binding("is.Date", x)) {
+ return("UTC")
Review comment:
Yep, my initial implementation did not return `"UTC"` for strings, etc.
and FWIW I think that is the way to go. I then proceeded to implement it in a
`lubridate`-like manner. That allows us to decide if we want to pair it back or
not. My vote would go for return timezone when timezone exists, otherwise
return `NA`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
