pitrou commented on a change in pull request #12408:
URL: https://github.com/apache/arrow/pull/12408#discussion_r805146224
##########
File path: cpp/src/arrow/util/tracing_internal.cc
##########
@@ -176,8 +176,23 @@ otel::trace::TracerProvider* GetTracerProvider() {
static nostd::shared_ptr<otel::trace::TracerProvider> provider =
InitializeTracing();
return provider.get();
}
+
+struct StorageSingleton {
+ StorageSingleton() : storage_(otel::context::GetDefaultStorage()) {
+ otel::context::RuntimeContext::SetRuntimeContextStorage(storage_);
Review comment:
Is it ok to do this in a library? Applications or libraries using Arrow
C++ may want to use their own context storage and will be surprised that Arrow
overrides it. @lidavidm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
