jonkeane commented on a change in pull request #12357:
URL: https://github.com/apache/arrow/pull/12357#discussion_r807286901
##########
File path: r/tests/testthat/test-dplyr-funcs-datetime.R
##########
@@ -711,3 +711,71 @@ test_that("am/pm mirror lubridate", {
)
})
+
+test_that("extract tz", {
+ df <- tibble(
+ x = as.POSIXct(c("2022-02-07", "2022-02-10"), tz = "Pacific/Marquesas"),
+ #lubridate::tz() returns -for the time being - "UTC" for NAs, strings,
+ #dates and numerics
+ y = c("2022-02-07", NA),
+ z = as.Date(c("2022-02-07", NA)),
+ w = c(1L, 5L),
+ v = c(1.1, 2.47)
+ )
+
+ compare_dplyr_binding(
+ .input %>%
+ mutate(timezone_x = tz(x)) %>%
+ collect(),
+ df
+ )
+
+ expect_snapshot(
+ compare_dplyr_binding(
+ .input %>%
+ mutate(
+ timezone_y = tz(x),
+ timezone_z = tz(y)
+ ) %>%
+ collect(),
+ df
+ ),
+ error = TRUE
Review comment:
OH, sorry I was off one level of the nesting. I might be
misunderstanding the output that you're seeing there, but I interpret that as
the snapshot is recording that there's no output (i.e. the expectation has
passed). Which is what we expect with `warning = TRUE`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
