gsserge commented on a change in pull request #1324:
URL: https://github.com/apache/arrow-rs/pull/1324#discussion_r808491994
##########
File path: arrow/src/csv/writer.rs
##########
@@ -97,6 +97,7 @@ pub struct Writer<W: Write> {
/// The object to write to
writer: csv_crate::Writer<W>,
/// Column delimiter. Defaults to `b','`
+ #[allow(dead_code)]
Review comment:
Yep, this time the delimiter is configured via the builder, but gets
completely ignored
```rust
impl<W: Write> Writer<W> {
/// Create a new CsvWriter from a writable object, with default options
pub fn new(writer: W) -> Self {
let delimiter = b',';
let mut builder = csv_crate::WriterBuilder::new();
let writer = builder.delimiter(delimiter).from_writer(writer);
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
