jorisvandenbossche commented on a change in pull request #12449:
URL: https://github.com/apache/arrow/pull/12449#discussion_r809089172
##########
File path: cpp/src/parquet/arrow/arrow_schema_test.cc
##########
@@ -139,6 +139,10 @@ TEST_F(TestConvertParquetSchema, ParquetFlatPrimitives) {
arrow_fields.push_back(
::arrow::field("time64", ::arrow::time64(TimeUnit::MICRO), false));
+ parquet_fields.push_back(
+ PrimitiveNode::Make("duration[us]", Repetition::REQUIRED,
ParquetType::INT64));
+ arrow_fields.push_back(::arrow::field("duration[us]", INT64, false));
Review comment:
Ah, I initially wrote the test with duration type, but because this test
is for the pure Parquet->Arrow schema conversion (without any usage of
ARROW:schema), it failed and I changed it to int64. Which of course renders it
useless as it's indeed just testing int64 type. Will remove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
