lidavidm commented on a change in pull request #12116:
URL: https://github.com/apache/arrow/pull/12116#discussion_r809179785



##########
File path: cpp/src/arrow/device.h
##########
@@ -223,4 +236,55 @@ class ARROW_EXPORT CPUMemoryManager : public MemoryManager 
{
 ARROW_EXPORT
 std::shared_ptr<MemoryManager> default_cpu_memory_manager();
 
+/// A memory manager that uses the immutable zeros interface of the given 
memory pool,
+/// rather than the normal mutable buffer interface.

Review comment:
       You do have good points. These abstractions are rather new, or at least 
under-used, and could be refined.
   
   Most APIs do indeed work with MemoryPool, not MemoryManager; MemoryPool has 
been there for quite a long time, and MemoryManager was only added relatively 
recently, to support non-CPU memory. The right place would be JIRA and/or the 
ML, I think. (Or just an ML post referencing this thread; GitHub is OK for 
discussion, we might just need more eyes.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to