alamb commented on pull request #1330: URL: https://github.com/apache/arrow-rs/pull/1330#issuecomment-1043274603
> Thanks @alamb . As we don't know if the keys in key iterator are fully in the valid range,seems we cannot skipping bounds check in take_iter? That is true in general. However, if we are iterating over a set of keys from a known valid `DictionaryArray` the indexes are known to be valid > If it is critical, maybe we can have take_iter_unchecked in the future if it is necessary? I think this is wise strategy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
