kou commented on a change in pull request #12448:
URL: https://github.com/apache/arrow/pull/12448#discussion_r809574416



##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -359,10 +359,19 @@ foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
     continue()
   endif()
 
-  # For debugging
-  message(STATUS "${_VARIABLE_NAME}: ${_VARIABLE_VALUE}")
+  # Allow values to be overridden to test specific versions during development

Review comment:
       This feature will be useful when when we use custom `ARROW_XXX_URL` 
environment variable to use other version.
   But mixing environment variables and CMake variables confuses us. So another 
approach may be better.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to