rok commented on a change in pull request #12215:
URL: https://github.com/apache/arrow/pull/12215#discussion_r812082226
##########
File path: cpp/src/arrow/compute/kernels/codegen_internal_test.cc
##########
@@ -202,6 +202,8 @@ TEST(TestDispatchBest, CommonTemporalResolution) {
ASSERT_EQ(TimeUnit::MILLI, CommonTemporalResolution(args.data(),
args.size()));
args = {time64(TimeUnit::MICRO), duration(TimeUnit::NANO)};
ASSERT_EQ(TimeUnit::NANO, CommonTemporalResolution(args.data(),
args.size()));
+ args = {duration(TimeUnit::SECOND), int64()};
+ ASSERT_EQ(TimeUnit::SECOND, CommonTemporalResolution(args.data(),
args.size()));
Review comment:
Well duration has a unit and int64 is dimensionless. The goal of the
function is to find the best common unit and I'd argue it still does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
