nevi-me commented on pull request #1341: URL: https://github.com/apache/arrow-rs/pull/1341#issuecomment-1049577672
> It might be better from the API perspective for the `with_bounds()` method to have explicit `start` and `end` parameters instead of wrapping a tuple in `Some`: `.with_bounds(0, 2)` instead of `.with_bounds(Some((0, 2)))`. I think either approach is fine, we would often pass an Option in case one wants to reset an optional value. in practise though, I don't know whether a readerbuilder can be reused, as it could be cheap to create a new one with different configs. I'll merge this one for now, and then if you'd like to update to exclude the Option, we can do that before the next major release to avoid breaking changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
