cyb70289 commented on pull request #12574: URL: https://github.com/apache/arrow/pull/12574#issuecomment-1060122050
> I'm slightly ambivalent on reversing the population direction, it seems border line like change just for the sake of change. I don't recall if the reverse population was necessary for some reason that has changed or just an overcomplicating on my part. If you think it makes things easier to understand I'll do a more a thorough review Thanks @emkornfield. I agree change just for the sake of change is not good. As I commented above, this change may make further optimization easier. And I do think it simplifies the code. Reading input strings forward continuously is also more friendly to prefetcher, though this workload is cpu bound. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
