mingmwang commented on pull request #1924: URL: https://github.com/apache/arrow-datafusion/pull/1924#issuecomment-1064003994
> From what I can see the basic structure now looks good, but I don't feel I ca > Hi @mingmwang -- thank you for taking feedback and removing the global singleton. > > Sadly, realistically I am not going to be able to find enough contiguous time to carefully review this PR as written. It changes too many fundamental structures to DataFusion (like `ExecutionContext`) in non trivial ways. > > From what I can see the basic structure now looks good, but I don't feel I can evaluate the implications of this PR as a whole. > > If other maintainers feel differently, I will defer to their judgement and don't oppose merging this and sorting out any fallout afterwards. However, I stand with my original suggestion to break this into smaller parts that can be evaluated separately. Hi, @alamb Could you please guide me that who else can review this PR ? Sorry for pushing this hard, I need to close this the early the better so that I can continue the working on other parts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
