save-buffer commented on a change in pull request #12605:
URL: https://github.com/apache/arrow/pull/12605#discussion_r825492030
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -1844,10 +1844,14 @@ macro(build_gtest)
set(GTEST_VENDORED TRUE)
set(GTEST_CMAKE_CXX_FLAGS ${EP_CXX_FLAGS})
- if(CMAKE_BUILD_TYPE MATCHES DEBUG)
- set(CMAKE_GTEST_DEBUG_EXTENSION "d")
+ if(NOT CMAKE_GENERATOR STREQUAL Xcode)
Review comment:
As for generator expression, I got a lot of repeating of this:
```
CMake Error at
/opt/homebrew/Cellar/cmake/3.22.3/share/cmake/Modules/ExternalProject.cmake:2406:EVAL:2
(add_custom_command):
Error evaluating generator expression:
$<$<CONFIG:Debug>,d>
Expression did not evaluate to a known generator expression
```
Not too sure what to do about it, so I've not switched to generator
expression yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
