lukecwik commented on a change in pull request #11216: [BEAM-9562] Remove
TimerSpec from ParDoPayload
URL: https://github.com/apache/beam/pull/11216#discussion_r397940099
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -442,35 +442,30 @@ message ParDoPayload {
// be placed in the pipeline requirements.
map<string, StateSpec> state_specs = 4;
- // (Optional) A mapping of local timer names to timer specifications.
- // If this is set, the stateful processing requirement should also
- // be placed in the pipeline requirements.
- map<string, TimerSpec> timer_specs = 5;
-
- // (Optional) A mapping of local timer family names to timer specifications.
- // If this is set, the stateful processing requirement should also
- // be placed in the pipeline requirements.
- map<string, TimerFamilySpec> timer_family_specs = 9;
+ // (Optional) A mapping of local timer family names to timer family
+ // specifications. If this is set, the stateful processing requirement should
+ // also be placed in the pipeline requirements.
+ map<string, TimerFamilySpec> timer_family_specs = 8;
Review comment:
I would suggest not changing the proto tag numbers otherwise you'll have a
more difficult import/update issue with Google.
It will be much easier as a separate change to renumber them in increasing
order, so timer_family_specs is 5, restriction_coder_id is 6,
requests_finalization is 7, ... (making the import into Google much simpler to
do).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
