[GitHub] [beam] suztomo commented on issue #11216: [BEAM-9562] Remove TimerSpec from Proto

[GitBox]

suztomo commented on issue #11216: [BEAM-9562] Remove TimerSpec from Proto
URL: https://github.com/apache/beam/pull/11216#issuecomment-606158291
 
 
   @boyuanzz @lukecwik  beam_PostCommit_Java_ValidatesRunner_Dataflow started 
failing after this PR:
   
https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/4719/
   
   History:
   
   <img width="690" alt="Screen Shot 2020-03-30 at 14 07 08" 
src="https://user-images.githubusercontent.com/28604/77946079-c3421880-728f-11ea-9b0a-e5b55b078db8.png";>
   
   I see `Run Dataflow ValidatesRunner` was not tested in this PR.
   
   ```
   00:27:33 > Task 
:runners:google-cloud-dataflow-java:validatesRunnerLegacyWorkerTest
   00:28:48 
   00:28:48 org.apache.beam.sdk.transforms.ParDoTest$TimerFamilyTests > 
testTimerWithMultipleTimerFamilyUnbounded FAILED
   00:28:48     java.lang.RuntimeException at ParDoTest.java:4770
   00:28:48         Caused by: java.lang.IllegalArgumentException at 
ParDoTest.java:4770
   00:42:57 
   00:42:57 org.apache.beam.sdk.transforms.ParDoTest$TimerFamilyTests > 
testTimerFamilyEventTimeUnbounded FAILED
   00:42:57     java.lang.RuntimeException at ParDoTest.java:4708
   00:42:57         Caused by: java.lang.IllegalArgumentException at 
ParDoTest.java:4708
   ```
   
   I appreciate if you can check whether the failure is related to this PR.
   
   Created an issue: https://issues.apache.org/jira/browse/BEAM-9636

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services