pabloem commented on a change in pull request #11086: [BEAM-8910] Make custom
BQ source read from Avro
URL: https://github.com/apache/beam/pull/11086#discussion_r409090101
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -610,7 +611,8 @@ def __init__(
coder=None,
use_standard_sql=False,
flatten_results=True,
- kms_key=None):
+ kms_key=None,
+ use_json_exports=False):
Review comment:
not supporting JSON would increase the amount of changes that users need to
make to migrate to the new source, as the data output types would change. I
don't think this would be ideal. Wouldn't it be better to allow users to
migrate to the new source without having to change the rest of their pipeline?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
