boyuanzz commented on a change in pull request #11414: [BEAM-5605, BEAM-2939]
Add support for FnApiDoFnRunner to handle split calls.
URL: https://github.com/apache/beam/pull/11414#discussion_r409204369
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -761,72 +795,111 @@ public void processElementForElementAndRestriction(
continue;
}
- // Make sure to get the output watermark before we split to ensure
that the lower bound
- // applies to both the primary and residual.
- KV<Instant, WatermarkEstimatorStateT> watermarkAndState =
- currentWatermarkEstimator.getWatermarkAndState();
- SplitResult<RestrictionT> result = currentTracker.trySplit(0);
+ // Attempt to checkpoint the current restriction.
+ HandlesSplits.SplitResult splitResult =
Review comment:
Got it. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
