tvalentyn commented on a change in pull request #11548:
URL: https://github.com/apache/beam/pull/11548#discussion_r416962452
##########
File path: sdks/java/container/build.gradle
##########
@@ -101,16 +84,44 @@ docker {
project.rootProject["docker-tag"] : project.sdk_version)
dockerfile project.file("./${dockerfileName}")
files "./build/"
+ buildArgs(['pull_licenses':
!project.rootProject.hasProperty(["no-licenses"])])
Review comment:
Right, so to produce lightweight images we can skip license download.
Why would we ever want to 'check' urls but not downloading the licenses? From
your comment:
```
I tried to check if urls are valid instead of pulling the files and it
reduced only 1 min of running time. So, it's not an option here.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
