mxm commented on a change in pull request #11556:
URL: https://github.com/apache/beam/pull/11556#discussion_r418947573
##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -535,7 +537,7 @@ def _last_error_message(self):
else:
return 'unknown error'
- def wait_until_finish(self):
+ def wait_until_finish(self, duration=None):
Review comment:
Agree that the parameter name/default is not optimally chosen. Added a
docstring.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
