ibzib commented on a change in pull request #11598:
URL: https://github.com/apache/beam/pull/11598#discussion_r419649174
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/BatchGroupAlsoByWindowViaIteratorsFn.java
##########
@@ -165,12 +168,17 @@ public WindowReiterable(
}
@Override
- public Reiterator<V> iterator() {
+ public WindowReiterator<V> iterator() {
Review comment:
It's odd that `ElementByteSizeObservableIterable::iterator` adds
observers within the method body. I assume this is for historic reasons, since
it doesn't seem to do anything now, and the comment documenting references a
`setObserver` method that doesn't exist. Anyway, your change looks fine. But we
should consider cleaning this up.
https://github.com/apache/beam/blob/6453e859badcb629ae2528b77d84235b7291ff89/sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ElementByteSizeObservableIterable.java#L49-L61
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
