kamilwu commented on a change in pull request #11567:
URL: https://github.com/apache/beam/pull/11567#discussion_r422163533
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test.py
##########
@@ -67,22 +82,30 @@ def _str_to_boolean(value):
class LoadTest(object):
+ """Base class for all integration and performance tests which export
+ metrics to external databases: BigQuery or/and InfluxDB.
+
+ Refer to :class:`~apache_beam.testing.load_tests.LoadTestOptions` for more
+ information on the required pipeline options.
+
+ If using InfluxDB with Basic HTTP authentication enabled, provide the
+ following environment options: `INFLUXDB_USER` and `INFLUXDB_USER_PASSWORD`.
Review comment:
If we did, we could put vulnerable data (like password) at risk by
exposing them in logs. Apart from that, I think the only way of using Jenkins
credentials are environment variables only
##########
File path: sdks/python/apache_beam/testing/load_tests/load_test.py
##########
@@ -67,22 +82,30 @@ def _str_to_boolean(value):
class LoadTest(object):
+ """Base class for all integration and performance tests which export
+ metrics to external databases: BigQuery or/and InfluxDB.
+
+ Refer to :class:`~apache_beam.testing.load_tests.LoadTestOptions` for more
+ information on the required pipeline options.
+
+ If using InfluxDB with Basic HTTP authentication enabled, provide the
+ following environment options: `INFLUXDB_USER` and `INFLUXDB_USER_PASSWORD`.
Review comment:
If we did, we could put vulnerable data (like password) at risk by
exposing them in logs. Apart from that, I think the only way of using Jenkins
credentials are environment variables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
