chadrik commented on a change in pull request #11038:
URL: https://github.com/apache/beam/pull/11038#discussion_r422387775
##########
File path: sdks/python/apache_beam/io/iobase.py
##########
@@ -95,8 +115,11 @@
#
# Type for start and stop positions are specific to the bounded source and must
# be consistent throughout.
-SourceBundle = namedtuple(
- 'SourceBundle', 'weight source start_position stop_position')
+SourceBundle = NamedTuple(
+ 'SourceBundle',
+ [('weight', Optional[float]), ('source', 'BoundedSource'),
Review comment:
There is one use that I see where it is None, on
`_SDFBoundedSourceRestrictionProvider`:
```python
def initial_restriction(self, element):
# type: (...) -> _SDFBoundedSourceWrapper._SDFBoundedSourceRestriction
# Get initial range_tracker from source
range_tracker = self._source.get_range_tracker(None, None)
return _SDFBoundedSourceWrapper._SDFBoundedSourceRestriction(
SourceBundle(
None,
self._source,
range_tracker.start_position(),
range_tracker.stop_position()))
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
