lukecwik commented on a change in pull request #11607: URL: https://github.com/apache/beam/pull/11607#discussion_r424831998
########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/WatermarkEstimator.java ########## @@ -44,4 +45,19 @@ * <p>The state returned must not be mutated. */ WatermarkEstimatorStateT getState(); + + /** + * Validates that a given watermark is within timestamp min and max bounds. + * + * @param watermark watermark to validate + */ + static void ensureWatermarkWithinBounds(Instant watermark) { Review comment: It makes more sense to add this method to BoundedWindow as it should apply to a lot more places then just WatermarkEstimators. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org