[GitHub] [beam] henryken commented on a change in pull request #11731: [BEAM-10018] Fix timestamps in two windowing Python katas

[GitBox]

henryken commented on a change in pull request #11731:
URL: https://github.com/apache/beam/pull/11731#discussion_r426224090



##########
File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task-info.yaml
##########
@@ -22,10 +22,10 @@ files:
 - name: task.py
   visible: true
   placeholders:
-  - offset: 1211
-    length: 163
+  - offset: 1243

Review comment:
       We need to fix the answer placeholders.
   
![image](https://user-images.githubusercontent.com/5459430/82137599-3c033100-984c-11ea-861f-539a2f804218.png)
   

##########
File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py
##########
@@ -16,6 +16,7 @@
 
 import datetime
 import time

Review comment:
       Remove unused import

##########
File path: learning/katas/python/Windowing/Adding Timestamp/ParDo/task.py
##########
@@ -24,30 +25,30 @@
 
 
 class Event:
-    def __init__(self, id, event, date):
+    def __init__(self, id, event, timestamp):
         self.id = id
         self.event = event
-        self.date = date
+        self.timestamp = timestamp

Review comment:
       Need to change the `task.html` description
   ```html
   Please assign each element a timestamp based on the the 
<code>Event.timestamp</code>
   ```

##########
File path: learning/katas/python/Windowing/Fixed Time Window/Fixed Time 
Window/task-info.yaml
##########
@@ -22,7 +22,7 @@ files:
 - name: task.py
   visible: true
   placeholders:
-  - offset: 2074
+  - offset: 2067

Review comment:
       Need to fix the answer placeholder
   
![image](https://user-images.githubusercontent.com/5459430/82137850-21ca5280-984e-11ea-94ac-1315ccfb9eb1.png)
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org