amaliujia commented on a change in pull request #11737:
URL: https://github.com/apache/beam/pull/11737#discussion_r426859494
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/BeamBuiltinAggregations.java
##########
@@ -347,4 +357,35 @@ public BigDecimal toBigDecimal(BigDecimal record) {
return record;
}
}
+
+ static class BitOr<T extends Number> extends CombineFn<T, BitOr.Accum, Long>
{
+ static class Accum {
Review comment:
I am thinking there is no need to define a class to wrap `long val`?
Just use `Long`?
Also you could consider this interface:
https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Sum.java#L129?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
