veblush commented on a change in pull request #11651:
URL: https://github.com/apache/beam/pull/11651#discussion_r427623777



##########
File path: 
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -489,6 +490,7 @@ class BeamModulePlugin implements Plugin<Project> {
         grpc_protobuf                               : 
"io.grpc:grpc-protobuf:$grpc_version",
         grpc_protobuf_lite                          : 
"io.grpc:grpc-protobuf-lite:$grpc_version",
         grpc_netty                                  : 
"io.grpc:grpc-netty:$grpc_version",
+        grpc_netty_shaded                           : 
"io.grpc:grpc-netty-shaded:$grpc_version",

Review comment:
       Note that current beam already has it from 
[gax-grpc](https://mvnrepository.com/artifact/com.google.api/gax-grpc/1.54.0) 
transitively. This can make sure that all these components are working with the 
same version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to