ihji commented on a change in pull request #11757:
URL: https://github.com/apache/beam/pull/11757#discussion_r428314117
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in already_added_containers:
# Do not add the pipeline environment again.
+ # Currently, Dataflow uses Docker container images to uniquely
+ # identify execution environments. Hence Dataflow executes all
+ # transforms that specify the same Docker container image in the
+ # same container. Dependencies of all environments that specify a
+ # given container image will be staged in the container for that
Review comment:
If you pick an alternative sentence above: `container instance` here too.
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -314,8 +314,15 @@ def __init__(
if container_image_url in already_added_containers:
# Do not add the pipeline environment again.
+ # Currently, Dataflow uses Docker container images to uniquely
+ # identify execution environments. Hence Dataflow executes all
+ # transforms that specify the same Docker container image in the
+ # same container. Dependencies of all environments that specify a
Review comment:
`the same Docker container image in the same container` sounds little
confusing to me. How about something like `the same Docker container image in
the single container instance`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
