pabloem commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r428877884
##########
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##########
@@ -610,7 +611,8 @@ def __init__(
coder=None,
use_standard_sql=False,
flatten_results=True,
- kms_key=None):
+ kms_key=None,
+ use_json_exports=False):
Review comment:
Restarting this discussion after some rebasing and preparing...
I think I'd prefer to allow users to choose the export file format. This is
what we do for writing to BQ in Java and Python. Allowing users to choose
output type for specific column types would add overhead of (if avro and
json_format_bytes: formatbytes; if avro and json_datetime_format:
formatdatetime; if not avro and not json_format_bytes: formatbytes; ...).
We can discourage users from using JSON (AVRO is already the default) - and
eventually stop supporting it if that makes sense. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
