robertwb commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434734464



##########
File path: sdks/python/apache_beam/typehints/opcodes.py
##########
@@ -120,7 +120,7 @@ def get_iter(state, unused_arg):
 
 def symmetric_binary_op(state, unused_arg):
   # TODO(robertwb): This may not be entirely correct...
-  b, a = state.stack.pop(), state.stack.pop()
+  b, a = Const.unwrap(state.stack.pop()), Const.unwrap(state.stack.pop())

Review comment:
       This was needed for my test. (It now correctly infers `x + 1` for ints 
`x`.) I thought it small enough to not merit a new PR. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to