ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434850943
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
-Prelease.releaseVersion=${RELEASE}-RC${RC_NUM} \
-Prelease.useAutomaticVersion=true --info --no-daemon
- echo "Please make sure gradle release succeed: "
- echo "1. release code has been pushed to github repo."
- echo "2. new rc tag has created in github."
+ git push "v${RELEASE}-RC${RC_NUM}"
Review comment:
Ah you're right about both. Fixed, PTAL
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
