tysonjh commented on a change in pull request #11933:
URL: https://github.com/apache/beam/pull/11933#discussion_r436071355
##########
File path:
sdks/java/extensions/sql/zetasql/src/test/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSQLDialectSpecTest.java
##########
@@ -837,7 +834,6 @@ public void testLikeAllowsEscapingBackslash() {
}
@Test
- @Ignore("Currently non UTF-8 values are coerced to UTF-8")
public void testThrowsErrorForNonUTF8() {
Review comment:
This test name doesn't seem correct after these changes. What is it
testing now? What about the previous assertions on throwing an exception for
invalid utf8?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
