saavan-google-intern commented on a change in pull request #11939:
URL: https://github.com/apache/beam/pull/11939#discussion_r436417090
##########
File path: sdks/python/apache_beam/typehints/typehints_test.py
##########
@@ -612,54 +613,70 @@ def test_match_type_variables(self):
hint.match_type_variables(typehints.Dict[int, str]))
-class SetHintTestCase(TypeHintTestCase):
+class BaseSetHintTest:
+ def __init__(self, string_type, py_type, beam_type, *args, **kwargs):
Review comment:
That was there to forward arguments needed for the TestCase constructor
but it looks like there is only one optional parameter,
[methodName](https://docs.python.org/3/library/unittest.html#unittest.TestCase),
so I've pushed a fix to inline the parameter and remove *args, **kwargs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
